Skip to content

Conversation

@vagadiya
Copy link
Contributor

@vagadiya vagadiya commented Apr 12, 2025

Fix AWS token expiry issue when cached token expires when using AWS Profile for Bedrock (#2469)

Context

When using AWS Bedrock profile setup, the cached token expires which even after refreshing results in having to restart the entire VS Code environment for Roo Code to pull the latest token.

Implementation

The ignoreCache parameter was set to true when creating the clientConfig credentials.

Screenshots

This is the behaviour whilst the session is working and when the token expires.

image

How to Test

This fix has been used internally with a custom built version of Roo Code for the past month and has been successful with no token expiry issues.

Get in Touch

vagadiya


Important

Fixes AWS token expiry issue by setting ignoreCache: true in fromIni() for clientConfig.credentials in AwsBedrockHandler.

  • Behavior:
    • Fixes AWS token expiry issue by setting ignoreCache: true in fromIni() for clientConfig.credentials in AwsBedrockHandler.
  • Testing:
    • Internally tested with a custom version of Roo Code for a month without token expiry issues.

This description was created by Ellipsis for 156e5b5. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2025

⚠️ No Changeset found

Latest commit: 156e5b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Apr 12, 2025
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@mrubens mrubens merged commit 628d232 into RooCodeInc:main Apr 13, 2025
19 checks passed
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 13, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 13, 2025
@vagadiya vagadiya deleted the fix_for_aws_token_expiry branch April 13, 2025 13:15
@dmarkey
Copy link
Contributor

dmarkey commented Apr 14, 2025

Just what I was looking for!

SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants